Reduce allocation size in test Gather_oveflow_check from 4GiB to >2GiB#27483
Merged
adrianlizarraga merged 4 commits intomainfrom Feb 28, 2026
Merged
Reduce allocation size in test Gather_oveflow_check from 4GiB to >2GiB#27483adrianlizarraga merged 4 commits intomainfrom
adrianlizarraga merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the memory allocation in the Gather_overflow_check test from ~4GiB to ~2.1GiB while maintaining the test's effectiveness in verifying the integer overflow fix from PR #27444. The test validates that the CPU Gather operator correctly handles output tensors with dimensions that exceed INT32_MAX.
Changes:
- Reduced test dimension from 65537 to 46341 (output shape from 65537×65537 to 46341×46341)
- Updated comments to reflect the new dimensions and calculation (2,147,488,281 elements, just over INT32_MAX)
- Removed the 32-bit platform skip since the new allocation size no longer overflows size_t on 32-bit platforms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ize. Increase Android emulator memory to 5GiB
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edgchen1
approved these changes
Feb 27, 2026
tianleiwu
approved these changes
Feb 28, 2026
tianleiwu
pushed a commit
that referenced
this pull request
Feb 28, 2026
#27483) ### Description This PR reduces the size of the memory allocation for expected outputs from ~4GiB to ~2GiB in the Gather_overflow_check test. The updated test still verifies that the integer overflow fix from PR #27444 is valid. That is, that the CPU Gather operator correctly handles output tensors with element counts that exceed INT32_MAX. Changes: - Reduced test dimension from 65537 to 46341 (output shape from 65537×65537 to 46341×46341), which results in a total number of elements that is just over INT32_MAX, which is required to test the bug fix. - The peak memory usage is reduced to ~4GiB + overhead. - Increase Android emulator memory to 5GiB (from 4GiB) to be able to run the test. ### Motivation Android CI fails to run the unit test introduced in #27444 due to memory usage that exceeds the Android emulator's default memory of 4GiB. This PR lowers the peak memory usage of the unit test and increases the Android emulator's memory by 1GiB.
tianleiwu
added a commit
that referenced
this pull request
Feb 28, 2026
This cherry-picks the following commits for the release: | Commit ID | PR Number | Commit Title | |-----------|-----------|-------------| | 2604d31 | #27480 | Move JAR testing pipelines to canonical pipeline template | | 0768f42 | #27483 | Reduce allocation size in test Gather_oveflow_check from 4GiB to >2GiB | --------- Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the size of the memory allocation for expected outputs from ~4GiB to ~2GiB in the Gather_overflow_check test. The updated test still verifies that the integer overflow fix from PR #27444 is valid. That is, that the CPU Gather operator correctly handles output tensors with element counts that exceed INT32_MAX.
Changes:
Motivation
Android CI fails to run the unit test introduced in #27444 due to memory usage that exceeds the Android emulator's default memory of 4GiB. This PR lowers the peak memory usage of the unit test and increases the Android emulator's memory by 1GiB.